netdev - Re: [PATCH net-next 1/2] xfrm: add the description of CHACHA20-POLY1305 for xfrm algorithm description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLesfwnwXZ22A0fA@gauss3.secunet.de>
Date: Wed, 19 Jul 2023 11:27:27 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Louis Peens <louis.peens@...igine.com>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Herbert Xu <herbert@...dor.apana.org.au>,
	Leon Romanovsky <leon@...nel.org>, Simon Horman <simon.horman@...igine.com>,
	Shihong Wang <shihong.wang@...igine.com>, <netdev@...r.kernel.org>,
	<oss-drivers@...igine.com>
Subject: Re: [PATCH net-next 1/2] xfrm: add the description of
 CHACHA20-POLY1305 for xfrm algorithm description

On Wed, Jul 19, 2023 at 11:18:29AM +0200, Louis Peens wrote:
> From: Shihong Wang <shihong.wang@...igine.com>
> 
> Add the description of CHACHA20-POLY1305 for xfrm algorithm description
> and set pfkey_supported to 1 so that xfrm supports that the algorithm
> can be offloaded to the NIC.
> 
> Signed-off-by: Shihong Wang <shihong.wang@...igine.com>
> Acked-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Louis Peens <louis.peens@...igine.com>
> ---
>  include/uapi/linux/pfkeyv2.h | 1 +
>  net/xfrm/xfrm_algo.c         | 9 ++++++++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/pfkeyv2.h b/include/uapi/linux/pfkeyv2.h
> index 8abae1f6749c..d0ab530e1069 100644
> --- a/include/uapi/linux/pfkeyv2.h
> +++ b/include/uapi/linux/pfkeyv2.h
> @@ -331,6 +331,7 @@ struct sadb_x_filter {
>  #define SADB_X_EALG_CAMELLIACBC		22
>  #define SADB_X_EALG_NULL_AES_GMAC	23
>  #define SADB_X_EALG_SM4CBC		24
> +#define SADB_X_EALG_CHACHA20_POLY1305	25

Please don't add new stuff to pfkey, use netlink instead. This interface
is deprecated and will go away someday.