netdev - Re: [PATCH bpf-next v5 2/8] bpf: Add fd-based tcx multi-prog infra with link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d96b725d-6a7f-9b80-04f2-27872b1b3ca4@iogearbox.net>
Date: Wed, 19 Jul 2023 16:15:15 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev,
 razor@...ckwall.org, sdf@...gle.com, john.fastabend@...il.com,
 dxu@...uu.xyz, joe@...ium.io, toke@...nel.org, davem@...emloft.net,
 bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 2/8] bpf: Add fd-based tcx multi-prog infra
 with link support

On 7/19/23 2:25 AM, Jakub Kicinski wrote:
> On Fri, 14 Jul 2023 16:15:39 +0200 Daniel Borkmann wrote:
>> +void tcx_inc(void)
>> +{
>> +	static_branch_inc(&tcx_needed_key);
>> +}
>> +EXPORT_SYMBOL_GPL(tcx_inc);
>> +
>> +void tcx_dec(void)
>> +{
>> +	static_branch_dec(&tcx_needed_key);
>> +}
>> +EXPORT_SYMBOL_GPL(tcx_dec);
> 
> Do these need to be exported? Otherwise:
> 
> Acked-by: Jakub Kicinski <kuba@...nel.org>

Thanks! Indeed not, I removed them for v6.