netdev - Re: [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7t8rbb7umd.fsf@redhat.com>
Date: Wed, 19 Jul 2023 12:07:22 -0400
From: Aaron Conole <aconole@...hat.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>,  dev@...nvswitch.org,
  davem@...emloft.net,  kuba@...nel.org,  Eric Dumazet
 <edumazet@...gle.com>,  Paolo Abeni <pabeni@...hat.com>,  Pravin B Shelar
 <pshelar@....org>,  Jamal Hadi Salim <jhs@...atatu.com>,  Cong Wang
 <xiyou.wangcong@...il.com>,  Jiri Pirko <jiri@...nulli.us>,  Pablo Neira
 Ayuso <pablo@...filter.org>,  Florian Westphal <fw@...len.de>,  Marcelo
 Ricardo Leitner <marcelo.leitner@...il.com>,  Davide Caratti
 <dcaratti@...hat.com>
Subject: Re: [PATCH net-next 1/3] netfilter: allow exp not to be removed in
 nf_ct_find_expectation

Xin Long <lucien.xin@...il.com> writes:

> Currently nf_conntrack_in() calling nf_ct_find_expectation() will
> remove the exp from the hash table. However, in some scenario, we
> expect the exp not to be removed when the created ct will not be
> confirmed, like in OVS and TC conntrack in the following patches.
>
> This patch allows exp not to be removed by setting IPS_CONFIRMED
> in the status of the tmpl.
>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---

LGTM

Acked-by: Aaron Conole <aconole@...hat.com>