netdev - Re: [PATCH] net: delete "<< 1U" cargo-culting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 19 Jul 2023 13:57:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
 edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: delete "<< 1U" cargo-culting

On Wed, 19 Jul 2023 14:29:05 +0300 Alexey Dobriyan wrote:
> > Indeed. Still this patch is quite invasive and the net benefit looks
> > quite marginal - if any at all.  
> 
> I have all tree converted, this is just net/ part.
> 
> Net(!) benefit is more readable code.

Please don't argue with the maintainer about subjective stuff.
The noise in the history is not worth this noop patch.

Do compilers warn about this unnecessary type annotation?
If they did, and you were planning to enable such warning kernel-wide -
that'd be the only reason which could make the change worth considering.