netdev - RE: [PATCH net-next v3 2/2] tools: ynl-gen: fix parse multi-attr enum attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jul 2023 21:09:21 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>
Subject: RE: [PATCH net-next v3 2/2] tools: ynl-gen: fix parse multi-attr enum
 attribute

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Wednesday, July 19, 2023 5:19 AM
>
>On Tue, 18 Jul 2023 18:22:25 +0200 Arkadiusz Kubalewski wrote:
>> +            if 'enum' in attr_spec:
>> +                decoded = self._decode_enum(int.from_bytes(attr.raw,
>"big"), attr_spec)
>
>why int.from_bytes(attr.raw, "big")?
>'decoded' already holds the integer at this point

Yes, will fix.

Thank you!
Arkadiusz