netdev - Re: [PATCH] tg3: fix array subscript out of bounds compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230718195414.4c6f359f@kernel.org>
Date: Tue, 18 Jul 2023 19:54:14 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Carlos Bilbao <carlos.bilbao@....com>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, davem@...emloft.net,
 edumazet@...gle.com, linux-kernel@...r.kernel.org, mchan@...adcom.com,
 netdev@...r.kernel.org, pabeni@...hat.com, prashant@...adcom.com,
 siva.kallam@...adcom.com
Subject: Re: [PATCH] tg3: fix array subscript out of bounds compilation
 error

On Tue, 18 Jul 2023 10:52:39 -0500 Carlos Bilbao wrote:
> >> Fix encountered compilation error in tg3.c where an array subscript was  
> > 
> > What is the error ?  
> 
> drivers/net/ethernet/broadcom/tg3.c: In function ‘tg3_init_one’:

What compiler are you using? Any extra flags?

I remember seeing this warning too, but I can't repro it now (gcc 13.1;
clang 16).

> >> above the array bounds of 'struct tg3_napi[5]'. Add an additional check in
> >> the for loop to ensure that it does not exceed the bounds of
> >> 'struct tg3_napi' (defined by TG3_IRQ_MAX_VECS).
> >>
> >> Reviewed-By: Carlos Bilbao <carlos.bilbao@....com>

We need a sign-off tag
-- 
pw-bot: cr