netdev - RE: [PATCH v1 net 1/2] af_unix: Fix fortify_panic() in unix_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3DADE655-EE51-4DB0-8CEC-C3791AB12129@kernel.org>
Date: Wed, 19 Jul 2023 15:34:33 -0700
From: Kees Cook <kees@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Kees Cook <keescook@...omium.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Breno Leitao <leitao@...ian.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org, syzkaller <syzkaller@...glegroups.com>
Subject: RE: [PATCH v1 net 1/2] af_unix: Fix fortify_panic() in unix_bind_bsd().

On July 19, 2023 3:26:35 PM PDT, Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:
>Kuniyuki Iwashima wrote:
>The extensive comments are really helpful to understand what's
>going on.
>
>An alternative would be to just cast sunaddr to a struct
>sockaddr_storage *ss and use that both here and in unix_mkname_bsd?
>It's not immediately trivial that the caller has always actually
>allocated one of those. But the rest becomes self documenting.

I would much prefer the internal APIs actually passed around the true sockaddr_storage pointer. This is what I did recently for NFS, for example:
https://git.kernel.org/linus/cf0d7e7f4520

-Kees

-- 
Kees Cook