netdev - Re: [PATCH v2 net 0/4] net: Support STP on bridge in non-root netns.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 08:50:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, roopa@...dia.com, razor@...ckwall.org,
 ebiederm@...ssion.com, hcoin@...etfountain.com, kuni1840@...il.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 0/4] net: Support STP on bridge in non-root netns.

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue, 18 Jul 2023 10:41:48 -0700 you wrote:
> Currently, STP does not work in non-root netns as llc_rcv() drops
> packets from non-root netns.
> 
> This series fixes it by making some protocol handlers netns-aware,
> which are called from llc_rcv() as follows:
> 
>   llc_rcv()
>   |
>   |- sap->rcv_func : registered by llc_sap_open()
>   |
>   |  * functions : regsitered by register_8022_client()
>   |    -> No in-kernel user call register_8022_client()
>   |
>   |  * snap_rcv()
>   |    |
>   |    `- proto->rcvfunc() : registered by register_snap_client()
>   |
>   |       * aarp_rcv()  : drop packets from non-root netns
>   |       * atalk_rcv() : drop packets from non-root netns
>   |
>   |  * stp_pdu_rcv()
>   |    |
>   |    `- garp_protos[]->rcv() : registered by stp_proto_register()
>   |
>   |       * garp_pdu_rcv() : netns-aware
>   |       * br_stp_rcv()   : netns-aware
>   |
>   |- llc_type_handlers[llc_pdu_type(skb) - 1]
>   |
>   |  * llc_sap_handler()  : NOT netns-aware (Patch 1)
>   |  * llc_conn_handler() : NOT netns-aware (Patch 2)
>   |
>   `- llc_station_handler
> 
> [...]

Here is the summary with links:
  - [v2,net,1/4] llc: Check netns in llc_dgram_match().
    https://git.kernel.org/netdev/net/c/9b64e93e83c2
  - [v2,net,2/4] llc: Check netns in llc_estab_match() and llc_listener_match().
    https://git.kernel.org/netdev/net/c/97b1d320f48c
  - [v2,net,3/4] llc: Don't drop packet from non-root netns.
    https://git.kernel.org/netdev/net/c/6631463b6e66
  - [v2,net,4/4] Revert "bridge: Add extack warning when enabling STP in netns."
    https://git.kernel.org/netdev/net/c/7ebd00a5a20c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html