netdev - Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 10:57:23 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Abel Wu <wuyun.abel@...edance.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, Shakeel Butt <shakeelb@...gle.com>, 
	Muchun Song <muchun.song@...ux.dev>, Andrew Morton <akpm@...ux-foundation.org>, 
	David Ahern <dsahern@...nel.org>, Yosry Ahmed <yosryahmed@...gle.com>, 
	"Matthew Wilcox (Oracle)" <willy@...radead.org>, Yu Zhao <yuzhao@...gle.com>, 
	Kefeng Wang <wangkefeng.wang@...wei.com>, Yafang Shao <laoar.shao@...il.com>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Martin KaFai Lau <martin.lau@...nel.org>, 
	Alexander Mikhalitsyn <alexander@...alicyn.com>, Breno Leitao <leitao@...ian.org>, 
	David Howells <dhowells@...hat.com>, Jason Xing <kernelxing@...cent.com>, 
	Xin Long <lucien.xin@...il.com>, Michal Hocko <mhocko@...e.com>, 
	Alexei Starovoitov <ast@...nel.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>, 
	"open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" <cgroups@...r.kernel.org>, 
	"open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" <linux-mm@...ck.org>
Subject: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of
 sockmem pressure

On Thu, Jul 20, 2023 at 9:59 AM Abel Wu <wuyun.abel@...edance.com> wrote:
>
> Gentle ping :)

I was hoping for some feedback from memcg experts.

You claim to fix a bug, please provide a Fixes: tag so that we can
involve original patch author.

Thanks.

>
> On 7/11/23 8:41 PM, Abel Wu wrote:
> > Now there are two indicators of socket memory pressure sit inside
> > struct mem_cgroup, socket_pressure and tcpmem_pressure.
> >
> > When in legacy mode aka. cgroupv1, the socket memory is charged
> > into a separate counter memcg->tcpmem rather than ->memory, so
> > the reclaim pressure of the memcg has nothing to do with socket's
> > pressure at all. While for default mode, the ->tcpmem is simply
> > not used.
> >
> > So {socket,tcpmem}_pressure are only used in default/legacy mode
> > respectively. This patch fixes the pieces of code that make mixed
> > use of both.
> >
> > Signed-off-by: Abel Wu <wuyun.abel@...edance.com>
> > ---
> >   include/linux/memcontrol.h | 4 ++--
> >   mm/vmpressure.c            | 8 ++++++++
> >   2 files changed, 10 insertions(+), 2 deletions(-)
> >