netdev - Re: [PATCH net-next 1/4] eth: tsnep: let page recycling happen with skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 19:55:13 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<gerhard@...leder-embedded.com>
Subject: Re: [PATCH net-next 1/4] eth: tsnep: let page recycling happen with
 skbs

On 2023/7/20 9:04, Jakub Kicinski wrote:
> tsnep builds an skb with napi_build_skb() and then calls

nit: an -> a ?

Othewise, LGTM.

Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>

> page_pool_release_page() for the page in which that skb's
> head sits. Use recycling instead, recycling of heads works
> just fine.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: gerhard@...leder-embedded.com
> ---
>  drivers/net/ethernet/engleder/tsnep_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
> index 84751bb303a6..079f9f6ae21a 100644
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -1333,7 +1333,7 @@ static void tsnep_rx_page(struct tsnep_rx *rx, struct napi_struct *napi,
>  
>  	skb = tsnep_build_skb(rx, page, length);
>  	if (skb) {
> -		page_pool_release_page(rx->page_pool, page);
> +		skb_mark_for_recycle(skb);
>  
>  		rx->packets++;
>  		rx->bytes += length;
>