netdev - Re: [PATCH net-next 0/4] net: page_pool: remove page_pool_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1f9597a-e8c6-2e55-4677-a9fa0d9c37eb@intel.com>
Date: Thu, 20 Jul 2023 16:28:26 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next 0/4] net: page_pool: remove
 page_pool_release_page()

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 19 Jul 2023 18:04:05 -0700

> page_pool_return_page() is a historic artefact from before
> recycling of pages attached to skbs was supported. Theoretical
> uses for it may be thought up but in practice all existing
> users can be converted to use skb_mark_for_recycle() instead.

For the series:

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Good to see that now all PP users use skb page recycling. Apart from
benefits for drivers obv, this also increases coverage for the related
PP code.

> 
> This code was previously posted as part of the memory provider RFC.
> 
> Jakub Kicinski (4):
>   eth: tsnep: let page recycling happen with skbs
>   eth: stmmac: let page recycling happen with skbs
>   net: page_pool: hide page_pool_release_page()
>   net: page_pool: merge page_pool_release_page() with
>     page_pool_return_page()
> 
>  Documentation/networking/page_pool.rst            | 11 ++++-------
>  drivers/net/ethernet/engleder/tsnep_main.c        |  2 +-
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |  4 ++--
>  include/net/page_pool.h                           | 10 ++--------
>  net/core/page_pool.c                              | 13 ++-----------
>  5 files changed, 11 insertions(+), 29 deletions(-)
> 

Thanks,
Olek