netdev - Re: [PATCH v1 net-next] net: Use sockaddr_storage for getsockopt(SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 09:32:43 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <willemdebruijn.kernel@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <leitao@...ian.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v1 net-next] net: Use sockaddr_storage for getsockopt(SO_PEERNAME).

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Thu, 20 Jul 2023 09:50:46 -0400
> Kuniyuki Iwashima wrote:
> > Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") started
> > applying strict rules to standard string functions.
> > 
> > It does not work well with conventional socket code around each protocol-
> > specific struct sockaddr_XXX, which is cast from sockaddr_storage and has
> > a bigger size than fortified functions expect.  (See Link)
> > 
> > We must cast the protocol-specific address back to sockaddr_storage
> > to call such functions.
> > 
> > However, in the case of getsockaddr(SO_PEERNAME), the rationale is a bit
> > unclear as the buffer is defined by char[128] which is the same size as
> > sockaddr_storage.
> > 
> > Let's use sockaddr_storage implicitly.
> 
> explicitly

Will fix in v2, thanks!


>  
> > Link: https://lore.kernel.org/netdev/20230720004410.87588-1-kuniyu@amazon.com/
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> 
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>