netdev - RE: [PATCH net v3 1/1] mlxbf_gige: Fix kernel panic at shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 21:11:53 +0000
From: Asmaa Mnebhi <asmaa@...dia.com>
To: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"sridhar.samudrala@...el.com" <sridhar.samudrala@...el.com>,
	"maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>,
	"olteanv@...il.com" <olteanv@...il.com>, David Thompson
	<davthompson@...dia.com>
Subject: RE: [PATCH net v3 1/1] mlxbf_gige: Fix kernel panic at shutdown

>  	.probe = mlxbf_gige_probe,
>  	.remove = mlxbf_gige_remove,
> -	.shutdown = mlxbf_gige_shutdown,
> +	.shutdown = mlxbf_gige_remove,

Actually, apologies for this commit in response to Sridhar's comment on v2. This will not work. Mlxbf_gige_remove() returns void while ".shutdown" expects to return an int.
Please advise on how to proceed. Should I send a v4 with the same patch as v2?