netdev - Re: [PATCH bpf-next v6 2/8] bpf: Add fd-based tcx multi-prog infra with link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f218f1d-3610-9112-2844-334399944164@iogearbox.net>
Date: Fri, 21 Jul 2023 14:53:05 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Yafang Shao <laoar.shao@...il.com>
Cc: ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev,
 razor@...ckwall.org, sdf@...gle.com, john.fastabend@...il.com,
 kuba@...nel.org, dxu@...uu.xyz, joe@...ium.io, toke@...nel.org,
 davem@...emloft.net, bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v6 2/8] bpf: Add fd-based tcx multi-prog infra
 with link support

On 7/20/23 4:13 AM, Yafang Shao wrote:
> On Wed, Jul 19, 2023 at 10:11 PM Daniel Borkmann <daniel@...earbox.net> wrote:
[...]
>> +static const struct bpf_link_ops tcx_link_lops = {
>> +       .release        = tcx_link_release,
>> +       .detach         = tcx_link_detach,
>> +       .dealloc        = tcx_link_dealloc,
>> +       .update_prog    = tcx_link_update,
>> +       .show_fdinfo    = tcx_link_fdinfo,
>> +       .fill_link_info = tcx_link_fill_info,
> 
> Should we show the tc link info in `bpftool link show` as well? I
> believe that `bpftool link show` is the appropriate command to display
> comprehensive information about all links.

Yep, good idea. I'll add this to my todo list to tackle for once I'm back
from travel.

Thanks,
Daniel