netdev - 回复: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SG2PR06MB5288FB4E5CB1FD5E0FB6D18BAE3FA@SG2PR06MB5288.apcprd06.prod.outlook.com>
Date: Fri, 21 Jul 2023 02:54:26 +0000
From: 杜敏杰 <duminjie@...o.com>
To: Mark Brown <broonie@...nel.org>
CC: Vladimir Oltean <olteanv@...il.com>, Richard Cochran
	<richardcochran@...il.com>, "open list:FREESCALE DSPI DRIVER"
	<linux-spi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, "open
 list:PTP HARDWARE CLOCK SUPPORT" <netdev@...r.kernel.org>, opensource.kernel
	<opensource.kernel@...o.com>
Subject:
 回复: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()

Hi Mark!

Thank you for your reply!
You said:

> The indentation on the second line is messed up here, it's far too indented.

Could you tell me what is the specification for indentation?

regards,
Minjie

--------------------
发件人: Mark Brown <broonie@...nel.org> 
发送时间: 2023年7月19日 20:43
收件人: 杜敏杰 <duminjie@...o.com>
抄送: Vladimir Oltean <olteanv@...il.com>; Richard Cochran <richardcochran@...il.com>; open list:FREESCALE DSPI DRIVER <linux-spi@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>; open list:PTP HARDWARE CLOCK SUPPORT <netdev@...r.kernel.org>; opensource.kernel <opensource.kernel@...o.com>
主题: Re: [PATCH v1] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()

On Wed, Jul 19, 2023 at 07:13:02AM +0000, 杜敏杰 wrote:

> -		dev_err(dev, "rx dma channel not available\n");
> -		ret = PTR_ERR(dma->chan_rx);
> -		return ret;
> +		return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
> +							"rx dma channel not available\n");

The indentation on the second line is messed up here, it's far too indented.