netdev - RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB5751EAB220E28AECF6153522C13FA@DM8PR11MB5751.namprd11.prod.outlook.com>
Date: Fri, 21 Jul 2023 15:28:34 +0000
From: "Ng, Boon Khai" <boon.khai.ng@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "Boon@...mtp.png.intel.com"
	<Boon@...mtp.png.intel.com>, "Khai@...mtp.png.intel.com"
	<Khai@...mtp.png.intel.com>, "\"Ng <boon.khai.ng\"@intel.com"
	<"Ng <boon.khai.ng"@intel.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "Shevchenko, Andriy" <andriy.shevchenko@...el.com>, "Tham, Mun Yew"
	<mun.yew.tham@...el.com>, "Swee, Leong Ching" <leong.ching.swee@...el.com>,
	"G Thomas, Rohan" <rohan.g.thomas@...el.com>, Shevchenko Andriy
	<andriy.shevchenko@...ux.intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
 net: snps,dwmac: Add description for rx-vlan-offload

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Friday, July 21, 2023 6:11 PM
> To: Boon@...mtp.png.intel.com; Khai@...mtp.png.intel.com; "Ng
> <boon.khai.ng"@intel.com; Giuseppe Cavallaro <peppe.cavallaro@...com>;
> Alexandre Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; netdev@...r.kernel.org; linux-stm32@...md-
> mailman.stormreply.com; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Cc: Ng, Boon Khai <boon.khai.ng@...el.com>; Shevchenko, Andriy
> <andriy.shevchenko@...el.com>; Tham, Mun Yew <mun.yew.tham@...el.com>;
> Swee, Leong Ching <leong.ching.swee@...el.com>; G Thomas, Rohan
> <rohan.g.thomas@...el.com>; Shevchenko Andriy
> <andriy.shevchenko@...ux.intel.com>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
> net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 08:26, Boon@...mtp.png.intel.com wrote:
> > From: Boon Khai Ng <boon.khai.ng@...el.com>
> >
> > This patch is to add the dts setting for the MAC controller on
> > synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
> > accelerated VLAN stripping. Once the hardware accelerated VLAN
> > stripping is turn on, the VLAN tag will be stripped by the
> 
> Subject prefix is totally bogus.
> 

Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is X (mean 10), so XGMAC.
Even the driver file I'm editing it is dw"xgmac".

> 
> > 10G Ethernet MAC.
> >
> > Signed-off-by: Boon Khai Ng <boon.khai.ng@...el.com>
> > Reviewed-by: Shevchenko Andriy <andriy.shevchenko@...ux.intel.com>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
> 

This is based on net-next repository suggested by the get maintainer script.

I got the latest net-next just now at the Commit-id b44693495af8 
which just committed yesterday.

$ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
Giuseppe Cavallaro <peppe.cavallaro@...com> (supporter:STMMAC ETHERNET DRIVER)
Alexandre Torgue <alexandre.torgue@...s.st.com> (supporter:STMMAC ETHERNET DRIVER)
Jose Abreu <joabreu@...opsys.com> (supporter:STMMAC ETHERNET DRIVER)
"David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <edumazet@...gle.com> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <pabeni@...hat.com> (maintainer:NETWORKING DRIVERS)
Maxime Coquelin <mcoquelin.stm32@...il.com> (maintainer:ARM/STM32 ARCHITECTURE)
Richard Cochran <richardcochran@...il.com> (maintainer:PTP HARDWARE CLOCK SUPPORT)
netdev@...r.kernel.org (open list:STMMAC ETHERNET DRIVER)
linux-stm32@...md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE)
linux-arm-kernel@...ts.infradead.org (moderated list:ARM/STM32 ARCHITECTURE)
linux-kernel@...r.kernel.org (open list)
git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

> You missed at least DT list (maybe more), so this won't be tested by automated
> tooling. Performing review on untested code might be a waste of time, thus I
> will skip this patch entirely till you follow the process allowing the patch to be
> tested.
> 

This is a new device bringup, thus the DT is not available yet. The DTS will be upstreamed
by my another colleague, unless, if I can upstream only my part on the setting? 

> Please kindly resend and include all necessary To/Cc entries.
> 
> Best regards,
> Krzysztof