netdev - Re: [PATCH net 0/3] net/sched Bind logic fixes for cls_fw, cls_u32 and cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkVVdHjU1aUxmjN7ah_iE2Beuwgf4r6ddxCWN5d77t-=A@mail.gmail.com>
Date: Fri, 21 Jul 2023 15:56:17 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: valis <sec@...is.email>, netdev@...r.kernel.org, xiyou.wangcong@...il.com, 
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, victor@...atatu.com, ramdhan@...rlabs.sg, 
	billy@...rlabs.sg
Subject: Re: [PATCH net 0/3] net/sched Bind logic fixes for cls_fw, cls_u32
 and cls_route

On Fri, Jul 21, 2023 at 3:00 PM Pedro Tammela <pctammela@...atatu.com> wrote:
>
> On 21/07/2023 14:48, valis wrote:
> > Three classifiers (cls_fw, cls_u32 and cls_route) always copy
> > tcf_result struct into the new instance of the filter on update.
> >
> > This causes a problem when updating a filter bound to a class,
> > as tcf_unbind_filter() is always called on the old instance in the
> > success path, decreasing filter_cnt of the still referenced class
> > and allowing it to be deleted, leading to a use-after-free.
> >
> > This patch set fixes this issue in all affected classifiers by no longer
> > copying the tcf_result struct from the old filter.
> >
> > valis (3):
> >    net/sched: cls_u32: No longer copy tcf_result on update to avoid
> >      use-after-free
> >    net/sched: cls_fw: No longer copy tcf_result on update to avoid
> >      use-after-free
> >    net/sched: cls_route: No longer copy tcf_result on update to avoid
> >      use-after-free
> >
> >   net/sched/cls_fw.c    | 1 -
> >   net/sched/cls_route.c | 1 -
> >   net/sched/cls_u32.c   | 1 -
> >   3 files changed, 3 deletions(-)
> >
>
> For the series,
>
> Reviewed-by: Pedro Tammela <pctammela@...atatu.com>
> Tested-by: Pedro Tammela <pctammela@...atatu.com>

For the series:
Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal