netdev - Re: [PATCH bpf-next v3 10/21] ice: Implement VLAN tag hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLo08euaO5pyEyly@lincoln>
Date: Fri, 21 Jul 2023 07:38:21 +0000
From: "Zaremba, Larysa" <larysa.zaremba@...el.com>
To: Simon Horman <simon.horman@...igine.com>
CC: "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "ast@...nel.org"
	<ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>,
	"andrii@...nel.org" <andrii@...nel.org>, "martin.lau@...ux.dev"
	<martin.lau@...ux.dev>, "song@...nel.org" <song@...nel.org>, "yhs@...com"
	<yhs@...com>, "john.fastabend@...il.com" <john.fastabend@...il.com>,
	"kpsingh@...nel.org" <kpsingh@...nel.org>, "sdf@...gle.com" <sdf@...gle.com>,
	"haoluo@...gle.com" <haoluo@...gle.com>, "jolsa@...nel.org"
	<jolsa@...nel.org>, David Ahern <dsahern@...il.com>, Jakub Kicinski
	<kuba@...nel.org>, Willem de Bruijn <willemb@...gle.com>, "Brouer, Jesper"
	<brouer@...hat.com>, "Burakov, Anatoly" <anatoly.burakov@...el.com>,
	"Lobakin, Aleksander" <aleksander.lobakin@...el.com>, Magnus Karlsson
	<magnus.karlsson@...il.com>, "Tahhan, Maryam" <mtahhan@...hat.com>,
	"xdp-hints@...-project.net" <xdp-hints@...-project.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 10/21] ice: Implement VLAN tag hint

On Thu, Jul 20, 2023 at 07:50:27PM +0100, Simon Horman wrote:
> On Wed, Jul 19, 2023 at 08:37:23PM +0200, Larysa Zaremba wrote:
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> > index b11cfaedb81c..4ad6db83674e 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> > @@ -639,7 +639,33 @@ static int ice_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash,
> >  	return 0;
> >  }
> >  
> > +/**
> > + * ice_xdp_rx_vlan_tag - VLAN tag XDP hint handler
> > + * @ctx: XDP buff pointer
> > + * @vlan_tci: destination address for VLAN tag
> > + * @vlan_proto: destination address for VLAN protocol
> > + *
> > + * Copy VLAN tag (if was stripped) and corresponding protocol
> > + * to the destination address.
> > + */
> > +static int ice_xdp_rx_vlan_tag(const struct xdp_md *ctx, u16 *vlan_tci,
> > +			       __be16 *vlan_proto)
> > +{
> > +	const struct ice_xdp_buff *xdp_ext = (void *)ctx;
> > +
> > +	*vlan_proto = xdp_ext->pkt_ctx.vlan_proto;
> > +	if (!*vlan_proto)
> > +		return -ENODATA;
> > +
> > +	*vlan_tci = ice_get_vlan_tci(xdp_ext->pkt_ctx.eop_desc);
> > +	if (!*vlan_tag)
> 
> Hi Larysa,
> 
> Should this be vlan_tci rather than vlan_tag?
> 

Yes! I have no idea, how this has happened >_<

> > +		return -ENODATA;
> > +
> > +	return 0;
> > +}
> > +
> 
> ...