netdev - Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230721-passive-smoked-d02c88721754@spud>
Date: Fri, 21 Jul 2023 10:16:41 +0100
From: Conor Dooley <conor@...nel.org>
To: Guo Samin <samin.guo@...rfivetech.com>
Cc: Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Hal Feng <hal.feng@...rfivetech.com>, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	netdev@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Emil Renner Berthing <kernel@...il.dk>,
	Richard Cochran <richardcochran@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jose Abreu <joabreu@...opsys.com>, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Peter Geis <pgwipeout@...il.com>,
	Yanhong Wang <yanhong.wang@...rfivetech.com>,
	Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC

On Fri, Jul 21, 2023 at 03:27:33PM +0800, Guo Samin wrote:

> -------- 原始信息 --------
> 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
> From: Conor Dooley <conor@...nel.org>

> 收件人: Guo Samin <samin.guo@...rfivetech.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Hal Feng <hal.feng@...rfivetech.com>, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, netdev@...r.kernel.org
> 日期: 2023/7/21

btw, please try and remove this stuff from your mails.

> > On 21 July 2023 03:09:19 IST, Guo Samin <samin.guo@...rfivetech.com> wrote:

> >> There is a question about the configuration of phy that I would like to consult you.
> >>
> >> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
> >> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
> >> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.
> >>
> >> Should I submit another pacthes based on riscv-dt-for-next? 
> > 
> > Huh, dtbs_check passed for these patches,
> > I didn't realise changes to the motorcomm stuff
> > were a dep. for this. I'll take a look later.

> After discussing with HAL, I have prepared the code and considered adding the following patch to 
> Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1])
> which will then send patches based on linux-next. What do you think? @Andrew @Conor

I think you are better off just sending the dts patch to me, adding a
dts patch that will not apply to net-next to your motorcomm driver series
will only really cause problems for the netdev patchwork automation.

> [1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@starfivetech.com

I meant to ack this yesterday, but it wasn't in my dt-binding review
queue. I'll go do that now.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)