netdev - Re: [PATCH] tg3: fix array subscript out of bounds compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLikifw2my5Dgs5v=f4mgtAE2qLU6HEM6A=Jhdn2JT2ybuA@mail.gmail.com>
Date: Fri, 21 Jul 2023 18:17:23 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Carlos Bilbao <carlos.bilbao@....com>
Cc: Jakub Kicinski <kuba@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>, davem@...emloft.net, 
	edumazet@...gle.com, linux-kernel@...r.kernel.org, mchan@...adcom.com, 
	netdev@...r.kernel.org, pabeni@...hat.com, prashant@...adcom.com, 
	siva.kallam@...adcom.com
Subject: Re: [PATCH] tg3: fix array subscript out of bounds compilation error

On Fri, Jul 21, 2023 at 3:45 PM Carlos Bilbao <carlos.bilbao@....com> wrote:
>
> On 7/18/23 9:54 PM, Jakub Kicinski wrote:
> > On Tue, 18 Jul 2023 10:52:39 -0500 Carlos Bilbao wrote:
> >>>> Fix encountered compilation error in tg3.c where an array subscript was
> >>>
> >>> What is the error ?
> >>
> >> drivers/net/ethernet/broadcom/tg3.c: In function ‘tg3_init_one’:
> >
> > What compiler are you using? Any extra flags?
>
> GCC version 13.1.1. No special flags.
>

I've reviewed the driver code.  tp->irq_max is always properly
initialized to 1 or TG3_IRQ_MAX_VECS.  So this gcc warning seems
bogus.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)