netdev - Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b77d09e1-8acb-48e5-5192-218e1bc948af@iogearbox.net>
Date: Sat, 22 Jul 2023 03:40:15 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: kuba@...nel.org
Cc: ast@...nel.org, bpf@...r.kernel.org, netdev@...r.kernel.org,
 syzbot+bdcf141f362ef83335cf@...kaller.appspotmail.com,
 syzbot+b202b7208664142954fa@...kaller.appspotmail.com,
 syzbot+14736e249bce46091c18@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon
 tcx_entry_free

On 7/22/23 1:33 AM, Daniel Borkmann wrote:
> On qdisc destruction, the ingress_destroy() needs to update the correct
> entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
> Therefore, fix the typo.
> 
> Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with link support")
> Reported-by: syzbot+bdcf141f362ef83335cf@...kaller.appspotmail.com
> Reported-by: syzbot+b202b7208664142954fa@...kaller.appspotmail.com
> Reported-by: syzbot+14736e249bce46091c18@...kaller.appspotmail.com
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Additionally, syzbot also tested that all 3 reports are fixed with this:

Tested-by: syzbot+bdcf141f362ef83335cf@...kaller.appspotmail.com
Tested-by: syzbot+b202b7208664142954fa@...kaller.appspotmail.com
Tested-by: syzbot+14736e249bce46091c18@...kaller.appspotmail.com