netdev - Re: [PATCH v12 vfio 1/7] vfio: Commonize combine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <907b25c6-b7a6-8065-87c5-af8b78b6bba8@amd.com>
Date: Sat, 22 Jul 2023 00:05:26 -0700
From: Brett Creeley <bcreeley@....com>
To: "Tian, Kevin" <kevin.tian@...el.com>,
 Brett Creeley <brett.creeley@....com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
 "jgg@...dia.com" <jgg@...dia.com>, "yishaih@...dia.com"
 <yishaih@...dia.com>,
 "shameerali.kolothum.thodi@...wei.com" <shameerali.kolothum.thodi@...wei.com>
Cc: "shannon.nelson@....com" <shannon.nelson@....com>
Subject: Re: [PATCH v12 vfio 1/7] vfio: Commonize combine_ranges for use in
 other VFIO drivers

On 7/21/2023 1:51 AM, Tian, Kevin wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> From: Brett Creeley <brett.creeley@....com>
>> Sent: Thursday, July 20, 2023 6:35 AM
>>
>> Currently only Mellanox uses the combine_ranges function. The
>> new pds_vfio driver also needs this function. So, move it to
>> a common location for other vendor drivers to use.
>>
>> Also, Simon Harmon noticed that RCT ordering was not followed
>> for vfio_combin_iova_ranges(), so fix that.
>>
> 
> It's not common practice to put name in the commit msg. Just
> describe what is changed.

Okay, I will keep that in mind in the future. Based on your other 
comments there are some minor tweaks that need to be done for a v13, so 
I will make sure to update this while I'm at it.

Thanks for the review.

Brett