netdev - Aw: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-d3292c8a-89e4-4d5e-838f-cdf1f65ff58b-1690029105348@3c-app-gmx-bs12>
Date: Sat, 22 Jul 2023 14:31:45 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Daniel Golle <daniel@...rotopia.org>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Arınç ÜNAL <arinc.unal@...nc9.com>, David
 Woodhouse <dwmw@...zon.co.uk>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Felix Fietkau
 <nbd@....name>, Jakub Kicinski <kuba@...nel.org>, John Crispin
 <john@...ozen.org>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, Lorenzo Bianconi <lorenzo@...nel.org>,
 Mark Lee <Mark-MC.Lee@...iatek.com>, Matthias Brugger
 <matthias.bgg@...il.com>, netdev@...r.kernel.org, Paolo Abeni
 <pabeni@...hat.com>, Sean Wang <sean.wang@...iatek.com>
Subject: Aw: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour

Hi

> Gesendet: Samstag, 22. Juli 2023 um 00:40 Uhr
> Von: "Daniel Golle" <daniel@...rotopia.org>
>
> Hi Russell,
>
> On Fri, Jul 21, 2023 at 12:33:52PM +0100, Russell King (Oracle) wrote:
> > Hi,
> >
> > This series removes the - as far as I can tell - unreachable code in
> > mtk_eth_soc that relies upon legacy phylink behaviour, and then removes
> > the support in phylink for this legacy behaviour.
> >
> > Patch 1 removes the clocking configuration from mtk_eth_soc for non-
> > TRGMII, non-serdes based interface modes, and disables those interface
> > modes prior to phylink configuration.
> >
> > Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which
> > I believe is also not used - mtk_eth_soc appears not to be used with
> > SFPs (which would use a kind of in-band mode) nor does any DT appear
> > to specify in-band mode for any non-serdes based interface mode.
> >
> > With both of those dealt with, the kernel is now free of any driver
> > relying on the phylink legacy mode. Therefore, patch 3 removes support
> > for this.
> >
> > Finally, with the advent of a new driver being submitted today that
> > makes use of state->speed in the mac_config() path, patch 4 ensures that
> > any phylink_link_state member that should not be used in mac_config is
> > either cleared or set to an invalid value.
>
> Thank you for taking care of this!

> For the whole series:
>
> Reviewed-by: Daniel Golle <daniel@...rotopia.org>
> Tested-by: Daniel Golle <daniel@...rotopia.org>
>
> Tested on BPi-R2 (MT7623N), BPi-R3 (MT7986A) and BPi-R64 (MT7622A).
> All works fine as expected.

have you changed anything?

in my test with bpi-r2 i see boot hangs after link-up on my wan-port (still trgmii-mode configured), no access to userspace.

[   10.881844] mtk_soc_eth 1b100000.ethernet eth0: configuring for fixed/trgmii link mode
[   10.891611] mtk_soc_eth 1b100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx
[   11.005814] mt7530-mdio mdio-bus:1f wan: configuring for phy/gmii link mode
[   11.016654] mt7530-mdio mdio-bus:1f lan3: configuring for phy/gmii link mode
[   11.025685] mt7530-mdio mdio-bus:1f lan2: configuring for phy/gmii link mode
[   11.035122] mt7530-mdio mdio-bus:1f lan1: configuring for phy/gmii link mode
[   11.045370] mt7530-mdio mdio-bus:1f lan0: configuring for phy/gmii link mode

[   15.144255] mt7530-mdio mdio-bus:1f wan: Link is Up - 1Gbps/Full - flow control rx/tx

removing the cable does not show link down so it looks like completely stalled...but also no panic/crash or similar.
When booting without cable it hangs too (without the up-message of course).

> To apply the series I needed to resolve a minor conflict due to
> net: ethernet: mtk_ppe: add MTK_FOE_ENTRY_V{1,2}_SIZE macros
> being applied in the meantime.

i used yesterdays net-next (6.5-rc2) and put series on top (also needed to do one hunk of first patch manually) and
then my defconfig,buildscript etc. maybe i miss anything?

afair trgmii is basicly rgmii only with higher clock-setting...and if this is dropped from mac-driver but switch is still using it it cannot work, but i'm sure you know this ;)

regards Frank