netdev - Re: [PATCH iproute2] bridge/mdb.c: include limits.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLzXOR6pS/2P+BUX@shredder>
Date: Sun, 23 Jul 2023 10:31:05 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Trevor Gamblin <tgamblin@...libre.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] bridge/mdb.c: include limits.h

On Thu, Jul 20, 2023 at 04:37:26PM -0400, Trevor Gamblin wrote:
> While building iproute2 6.4.0 with musl using Yocto Project, errors such
> as the following were encountered:
> 
> | mdb.c: In function 'mdb_parse_vni':
> | mdb.c:666:47: error: 'ULONG_MAX' undeclared (first use in this function)
> |   666 |         if ((endptr && *endptr) || vni_num == ULONG_MAX)
> |       |                                               ^~~~~~~~~
> | mdb.c:666:47: note: 'ULONG_MAX' is defined in header '<limits.h>'; did you forget to '#include <limits.h>'?
> 
> Include limits.h in bridge/mdb.c to fix this issue. This change is based
> on one in Alpine Linux, but the author there had no plans to submit:
> https://git.alpinelinux.org/aports/commit/main/iproute2/include.patch?id=bd46efb8a8da54948639cebcfa5b37bd608f1069
> 
> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>

Fixes: c5b327e5707b ("bridge: mdb: Add destination VNI support")
Reviewed-by: Ido Schimmel <idosch@...dia.com>

Similar change was done in commit dd9cc0ee81a6 ("iproute2: various
header include fixes for compiling with musl libc").

Thanks