netdev - Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2004b5c6-6bff-88a8-a3f2-cfe95f12996b@alu.unizg.hr>
Date: Sun, 23 Jul 2023 20:50:13 +0200
From: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To: Ido Schimmel <idosch@...sch.org>
Cc: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh:
 add cleanup for SIGTERM sent by timeout

On 7/23/23 19:27, Ido Schimmel wrote:
> On Sun, Jul 23, 2023 at 11:25:16AM +0300, Ido Schimmel wrote:
>> On Sat, Jul 22, 2023 at 02:36:00AM +0200, Mirsad Todorovac wrote:
>>> Add trap and cleanup for SIGTERM sent by timeout and SIGINT from
>>> keyboard, for the test times out and leaves incoherent network stack.
>>>
>>> Fixes: 511e8db54036c ("selftests: forwarding: Add test for custom multipath hash")
>>> Cc: Ido Schimmel <idosch@...dia.com>
>>> Cc: netdev@...r.kernel.org
>>> ---
>>
>> The patches are missing your Signed-off-by and a cover letter. Anyway,
>> please don't send a new version just yet. I'm not sure this is the
>> correct approach and I'm looking into it.
> 
> Please test with the following four patches on top of net.git:
> 
> https://github.com/idosch/linux/commits/submit/sefltests_fix_v1

Will do. Just applying.

However, I have upgraded to iproute2-next, maybe the error message should
give a hint on that, too ... That might relieve the pressure on developers
answering always the same questions ...

Kind regards,
Mirsad