netdev - Re: [Patch v3] bnx2x: Fix error recovering in switch configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL5k/kTC6dNKjFo4@corigine.com>
Date: Mon, 24 Jul 2023 13:48:14 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
Cc: kuba@...nel.org, aelior@...vell.com, davem@...emloft.net,
	edumazet@...gle.com, manishc@...vell.com, netdev@...r.kernel.org,
	pabeni@...hat.com, skalluru@...vell.com, drc@...ux.vnet.ibm.com,
	abdhalee@...ibm.com
Subject: Re: [Patch v3] bnx2x: Fix error recovering in switch configuration

On Wed, Jul 19, 2023 at 10:02:01PM +0000, Thinh Tran wrote:
> 
> As the BCM57810 and other I/O adapters are connected
> through a PCIe switch, the bnx2x driver causes unexpected
> system hang/crash while handling PCIe switch errors, if
> its error handler is called after other drivers' handlers.
> 
> In this case, after numbers of bnx2x_tx_timout(), the
> bnx2x_nic_unload() is  called, frees up resources and
> calls bnx2x_napi_disable(). Then when EEH calls its
> error handler, the bnx2x_io_error_detected() and
> bnx2x_io_slot_reset() also calling bnx2x_napi_disable()
> and freeing the resources.
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
> Reviewed-by: Manish Chopra <manishc@...vell.com>
> Tested-by: Abdul Haleem <abdhalee@...ibm.com>
> Tested-by: David Christensen <drc@...ux.vnet.ibm.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>