netdev - Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL51Wl3lTD/7U1i/@nvidia.com>
Date: Mon, 24 Jul 2023 09:58:02 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Brett Creeley <bcreeley@....com>
Cc: "Tian, Kevin" <kevin.tian@...el.com>,
	Brett Creeley <brett.creeley@....com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com" <shameerali.kolothum.thodi@...wei.com>,
	"shannon.nelson@....com" <shannon.nelson@....com>
Subject: Re: [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support

On Sat, Jul 22, 2023 at 12:17:34AM -0700, Brett Creeley wrote:
> > I wonder whether the logic about migration file can be generalized.
> > It's not very maintainable to have every migration driver implementing
> > their own code for similar functions.
> > 
> > Did I overlook any device specific setup required here?
> 
> There isn't device specific setup, but the other drivers were different
> enough that it wasn't a straight forward task. I think it might be possible
> to refactor the drivers to some common functionality here, but IMO this
> seems like a task that can be further explored once this series is merged.

You keep saying that but, things seem to be getting worse. There are
alot of migration drivers being posted right now with alot of copy and
paste from mlx5.

Jason