netdev - Re: [PATCH net] net: flower: fix stack-out-of-bounds in fl_set_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLb1gumSBimUMsfToY1-3ra3EOuNZV7h=Te27AjYexAXA@mail.gmail.com>
Date: Mon, 24 Jul 2023 18:38:25 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Zahari Doychev <zdoychev@...linear.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, 
	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	syzbot <syzkaller@...glegroups.com>, Simon Horman <simon.horman@...igine.com>, 
	Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net] net: flower: fix stack-out-of-bounds in fl_set_key_cfm()

On Mon, Jul 24, 2023 at 6:32 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Typical misuse of
>
>         nla_parse_nested(array, XXX_MAX, ...);
>
> array must be declared as
>
>         struct nlattr *array[XXX_MAX + 1];
>
> Fixes: 7cfffd5fed3e ("net: flower: add support for matching cfm fields")
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Simon Horman <simon.horman@...igine.com>
> Cc: Ido Schimmel <idosch@...dia.com>
> ---
>  net/sched/cls_flower.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
> index 8da9d039d964ea417700a2f59ad95a9ce52f5eab..3c7a272bf7c7cf7d4ae21b5370cbc428086d6979 100644
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -1709,7 +1709,7 @@ static int fl_set_key_cfm(struct nlattr **tb,
>                           struct fl_flow_key *mask,
>                           struct netlink_ext_ack *extack)
>  {
> -       struct nlattr *nla_cfm_opt[TCA_FLOWER_KEY_CFM_OPT_MAX];
> +       struct nlattr *nla_cfm_opt[TCA_FLOWER_KEY_CFM_OPT_MAX + 1];
>         int err;
>
>         if (!tb[TCA_FLOWER_KEY_CFM])
> --
> 2.41.0.487.g6d72f3e995-goog
>

Cc Zahari Doychev <zdoychev@...linear.com>