netdev - Re: [net 1/2] net: ethtool: Unify ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7e5c45-9961-3ac2-69ae-434191c9e11c@gmail.com>
Date: Mon, 24 Jul 2023 20:27:47 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Joe Damato <jdamato@...tly.com>, netdev@...r.kernel.org,
 saeedm@...dia.com, tariqt@...dia.com, ecree@...arflare.com, andrew@...n.ch,
 kuba@...nel.org, davem@...emloft.net, leon@...nel.org, pabeni@...hat.com,
 bhutchings@...arflare.com, arnd@...db.de
Cc: linux-kernel@...r.kernel.org
Subject: Re: [net 1/2] net: ethtool: Unify ETHTOOL_{G,S}RXFH rxnfc copy

On 23/07/2023 16:06, Joe Damato wrote:
> ETHTOOL_GRXFH correctly copies in the full struct ethtool_rxnfc when
> FLOW_RSS is set; ETHTOOL_SRXFH needs a similar code path to handle the
> FLOW_RSS case so that ethtool can set the flow hash for custom RSS
> contexts (if supported by the driver).
> 
> The copy code from ETHTOOL_GRXFH has been pulled out in to a helper so
> that it can be called in both ETHTOOL_{G,S}RXFH code paths.
> 
> Fixes: 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches")
> Signed-off-by: Joe Damato <jdamato@...tly.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com>