netdev - Re: [PATCH v3 bpf 1/2] bpf: fix skb_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a5c27e4-a1a3-1fe5-a179-bfd0072e7c59@web.de>
Date: Tue, 25 Jul 2023 07:10:52 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yan Zhai <yan@...udflare.com>, kernel-team@...udflare.com,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Andrii Nakryiko <andrii@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jiri Olsa <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 KP Singh <kpsingh@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 Mykola Lysenko <mykolal@...com>, Paolo Abeni <pabeni@...hat.com>,
 Shuah Khan <shuah@...nel.org>, Song Liu <song@...nel.org>,
 Yonghong Song <yhs@...com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jordan Griege <jgriege@...udflare.com>, Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH v3 bpf 1/2] bpf: fix skb_do_redirect return values

>                                      … unexpected problems. This change
> converts the positive status code to proper error code.

Please choose a corresponding imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94

Did you provide sufficient justification for a possible addition of the tag “Fixes”?

…
> v2: code style change suggested by Stanislav Fomichev
> ---
>  net/core/filter.c | 12 +++++++++++-
…

How do you think about to replace this marker by a line break?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n711

Regards,
Markus