netdev - Re: [PATCH net] s390/lcs: Remove FDDI option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL96ut0OJdY8F3s+@corigine.com>
Date: Tue, 25 Jul 2023 09:33:14 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH net] s390/lcs: Remove FDDI option

On Mon, Jul 24, 2023 at 03:15:46PM +0200, Alexandra Winter wrote:
> The last s390 machine that supported FDDI was z900 ('7th generation',
> released in 2000). The oldest machine generation currently supported by
> the Linux kernel is MARCH_Z10 (released 2008). If there is still a usecase
> for connecting a Linux on s390 instance to a LAN Channel Station (LCS), it
> can only do so via Ethernet.
> 
> Randy Dunlap[1] found that LCS over FDDI has never worked, when FDDI
> was compiled as module. Instead of fixing that, remove the FDDI option
> from the lcs driver.
> 
> While at it, make the CONFIG_LCS description a bit more helpful.
> 
> References:
> [1] https://lore.kernel.org/netdev/20230621213742.8245-1-rdunlap@infradead.org/
> 
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
> Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Probably this is for 'net-next' rather than 'net'.
But in any case this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>