netdev - Re: [PATCH net-next 1/2] net: ngbe: add ncsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL+8dXjEmw9gyiBB@corigine.com>
Date: Tue, 25 Jul 2023 14:13:41 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	"Russell King (Oracle)" <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Andrew Lunn <andrew@...n.ch>, Jiawen Wu <jiawenwu@...stnetic.com>
Subject: Re: [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun
 nics

On Mon, Jul 24, 2023 at 05:24:59PM +0800, Mengyuan Lou wrote:

+ Jakub Kicinski, "Russell King (Oracle)", "David S. Miller", Paolo Abeni,
  Eric Dumazet, Heiner Kallweit, Andrew Lunn, Jiawen Wu

  Please use ./scripts/get_maintainer.pl --git-min-percent 25 this.patch
  to determine the CC list for Networking patches

> Add ncsi_enabled flag to struct netdev to indicate wangxun
> nics which support NCSI.

This patch adds ncsi_enabled to struct net_device.
Which does raise the question of if other NICs support NCSI,
and if so how they do so without this field.

This patch also renames an existing field in struct wx.
This is not reflected in the patch description.

> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>
> ---
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  | 2 +-
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 5 +++--
>  include/linux/netdevice.h                     | 3 +++
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> index 1de88a33a698..1b932e66044e 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> @@ -851,7 +851,7 @@ struct wx {
>  	struct phy_device *phydev;
>  
>  	bool wol_hw_supported;
> -	bool ncsi_enabled;
> +	bool ncsi_hw_supported;
>  	bool gpio_ctrl;
>  	raw_spinlock_t gpio_lock;
>  
> diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> index 2b431db6085a..e42e4dd26700 100644
> --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> @@ -63,8 +63,8 @@ static void ngbe_init_type_code(struct wx *wx)
>  		       em_mac_type_mdi;
>  
>  	wx->wol_hw_supported = (wol_mask == NGBE_WOL_SUP) ? 1 : 0;
> -	wx->ncsi_enabled = (ncsi_mask == NGBE_NCSI_MASK ||
> -			   type_mask == NGBE_SUBID_OCP_CARD) ? 1 : 0;
> +	wx->ncsi_hw_supported = (ncsi_mask == NGBE_NCSI_MASK ||
> +				 type_mask == NGBE_SUBID_OCP_CARD) ? 1 : 0;
>  
>  	switch (type_mask) {
>  	case NGBE_SUBID_LY_YT8521S_SFP:
> @@ -639,6 +639,7 @@ static int ngbe_probe(struct pci_dev *pdev,
>  	netdev->wol_enabled = !!(wx->wol);
>  	wr32(wx, NGBE_PSR_WKUP_CTL, wx->wol);
>  	device_set_wakeup_enable(&pdev->dev, wx->wol);
> +	netdev->ncsi_enabled = wx->ncsi_hw_supported;
>  
>  	/* Save off EEPROM version number and Option Rom version which
>  	 * together make a unique identify for the eeprom
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index b828c7a75be2..dfa14e4c8e95 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2024,6 +2024,8 @@ enum netdev_ml_priv_type {
>   *
>   *	@wol_enabled:	Wake-on-LAN is enabled
>   *
> + *	@ncsi_enabled:	NCSI is enabled.
> + *
>   *	@threaded:	napi threaded mode is enabled
>   *
>   *	@net_notifier_list:	List of per-net netdev notifier block
> @@ -2393,6 +2395,7 @@ struct net_device {
>  	struct lock_class_key	*qdisc_tx_busylock;
>  	bool			proto_down;
>  	unsigned		wol_enabled:1;
> +	unsigned		ncsi_enabled:1;
>  	unsigned		threaded:1;
>  
>  	struct list_head	net_notifier_list;
> -- 
> 2.41.0
> 
>