netdev - Re: [PATCH v1] bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e56edca.e264e.1898a641853.Coremail.linma@zju.edu.cn>
Date: Tue, 25 Jul 2023 08:12:42 +0800 (GMT+08:00)
From: "Lin Ma" <linma@....edu.cn>
To: "Jakub Kicinski" <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	ast@...nel.org, martin.lau@...nel.org, yhs@...com, andrii@...nel.org, 
	void@...ifault.com, houtao1@...wei.com, laoar.shao@...il.com, 
	inwardvessel@...il.com, kuniyu@...zon.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v1] bpf: Add length check for
 SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing

Hi Jakub,

> 
> You can move this check earlier, when the attributes are getting
> counted. That way we can avoid the alloc/free on error.

Good point, will fix that and prepare another patch

Thanks
Lin