netdev - Re: [PATCH net] bcmasp: BCMASP should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2d45566-b96c-5505-1f7e-92c6f33c08dd@broadcom.com>
Date: Tue, 25 Jul 2023 13:35:12 -0700
From: Justin Chen <justin.chen@...adcom.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Simon Horman <simon.horman@...igine.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB

On 7/25/23 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Justin Chen <justin.chen@...adcom.com>

> ---
>   drivers/net/ethernet/broadcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index d4166141145d631c..75ca3ddda1f5e09f 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -257,6 +257,7 @@ config BNXT_HWMON
>   
>   config BCMASP
>   	tristate "Broadcom ASP 2.0 Ethernet support"
> +	depends on ARCH_BRCMSTB || COMPILE_TEST
>   	default ARCH_BRCMSTB
>   	depends on OF
>   	select MII

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)