netdev - Re: [iproute2] bridge: link: allow filtering on bridge name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jul 2023 23:48:16 +0200
From: "Nicolas Escande" <nico.escande@...il.com>
To: "Stephen Hemminger" <stephen@...workplumber.org>
Cc: <netdev@...r.kernel.org>
Subject: Re: [iproute2] bridge: link: allow filtering on bridge name

On Tue Jul 25, 2023 at 6:37 PM CEST, Stephen Hemminger wrote:
> On Tue, 25 Jul 2023 11:22:42 +0200
> Nicolas Escande <nico.escande@...il.com> wrote:
>
> > When using 'brige link show' we can either dump all links enslaved to any bridge
> > (called without arg ) or display a single link (called with dev arg).
> > However there is no way to dummp all links of a single bridge.
> > 
> > To do so, this adds new optional 'master XXX' arg to 'bridge link show' command.
> > usage: bridge link show master br0
> > 
> > Signed-off-by: Nicolas Escande <nico.escande@...il.com>
>
> Looks good to me, but we really need to address removing the term master
> from bridge utility.

If you have a better term I can respin it.
But the thing is 'master' is still the most widely used and understood word when
it comes to bridge terminology. And as you said we have it in the output of many
'ip' and 'bridge' commands, that why IMHO it's the term we should use for now...

On another note, there is a slight indentation problem in the new if in
print_linkinfo(), if that can be corrected when the patch gets picked up that
would be perfect, otherwise I can send a v2.