netdev - Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev>
Date: Tue, 25 Jul 2023 11:23:54 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 david@...morbit.com,
 tkhai@...ru,
 Vlastimil Babka <vbabka@...e.cz>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 djwong@...nel.org,
 Christian Brauner <brauner@...nel.org>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 tytso@....edu,
 steven.price@....com,
 cel@...nel.org,
 Sergey Senozhatsky <senozhatsky@...omium.org>,
 yujie.liu@...el.com,
 Greg KH <gregkh@...uxfoundation.org>,
 LKML <linux-kernel@...r.kernel.org>,
 Linux Memory Management List <linux-mm@...ck.org>,
 x86@...nel.org,
 kvm@...r.kernel.org,
 xen-devel@...ts.xenproject.org,
 linux-erofs@...ts.ozlabs.org,
 linux-f2fs-devel@...ts.sourceforge.net,
 cluster-devel@...hat.com,
 linux-nfs@...r.kernel.org,
 linux-mtd@...ts.infradead.org,
 rcu@...r.kernel.org,
 netdev <netdev@...r.kernel.org>,
 dri-devel@...ts.freedesktop.org,
 linux-arm-msm@...r.kernel.org,
 dm-devel@...hat.com,
 linux-raid@...r.kernel.org,
 linux-bcache@...r.kernel.org,
 virtualization@...ts.linux-foundation.org,
 linux-fsdevel@...r.kernel.org,
 linux-ext4@...r.kernel.org,
 linux-xfs@...r.kernel.org,
 linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a
 separate file

> On Jul 25, 2023, at 11:09, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> 
> 
> On 2023/7/25 10:35, Muchun Song wrote:
>>> On Jul 24, 2023, at 17:43, Qi Zheng <zhengqi.arch@...edance.com> wrote:
>>> 
>>> The mm/vmscan.c file is too large, so separate the shrinker-related
>>> code from it into a separate file. No functional changes.
>>> 
>>> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
>>> ---
>>> include/linux/shrinker.h |   3 +
>>> mm/Makefile              |   4 +-
>>> mm/shrinker.c            | 707 +++++++++++++++++++++++++++++++++++++++
>>> mm/vmscan.c              | 701 --------------------------------------
>>> 4 files changed, 712 insertions(+), 703 deletions(-)
>>> create mode 100644 mm/shrinker.c
>>> 
>>> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
>>> index 224293b2dd06..961cb84e51f5 100644
>>> --- a/include/linux/shrinker.h
>>> +++ b/include/linux/shrinker.h
>>> @@ -96,6 +96,9 @@ struct shrinker {
>>>  */
>>> #define SHRINKER_NONSLAB (1 << 3)
>>> 
>>> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg,
>>> +    int priority);
>> A good cleanup, vmscan.c is so huge.
>> I'd like to introduce a new header in mm/ directory and contains those
>> declarations of functions (like this and other debug function in
>> shrinker_debug.c) since they are used internally across mm.
> 
> How about putting them in the mm/internal.h file?

Either is fine to me.

> 
>> Thanks.