netdev - Re: [PATCH net] igc: Fix Kernel Panic during ndo_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 10:07:56 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>,
	sasha.neftin@...el.com,
	Alejandra Victoria Alcaraz <alejandra.victoria.alcaraz@...el.com>,
	Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net] igc: Fix Kernel Panic during ndo_tx_timeout callback

On Mon, Jul 24, 2023 at 09:12:50AM -0700, Tony Nguyen wrote:
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
> 
> The Xeon validation group has been carrying out some loaded tests
> with various HW configurations, and they have seen some transmit
> queue time out happening during the test. This will cause the
> reset adapter function to be called by igc_tx_timeout().
> Similar race conditions may arise when the interface is being brought
> down and up in igc_reinit_locked(), an interrupt being generated, and
> igc_clean_tx_irq() being called to complete the TX.
> 
> When the igc_tx_timeout() function is invoked, this patch will turn
> off all TX ring HW queues during igc_down() process. TX ring HW queues
> will be activated again during the igc_configure_tx_ring() process
> when performing the igc_up() procedure later.
> 
> This patch also moved existing igc_disable_tx_ring_hw() to avoid using
> forward declaration.

...

> Fixes: 9b275176270e ("igc: Add ndo_tx_timeout support")
> Tested-by: Alejandra Victoria Alcaraz <alejandra.victoria.alcaraz@...el.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
> Acked-by: Sasha Neftin <sasha.neftin@...el.com>
> Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

...