netdev - Re: [PATCH net-next v2 1/2] r8152: adjust generic_ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c63b0f24-4e6b-4df3-8783-9899d178b16e@lunn.ch>
Date: Wed, 26 Jul 2023 10:36:46 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Hayes Wang <hayeswang@...ltek.com>
Cc: kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
	nic_swsd@...ltek.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function

On Wed, Jul 26, 2023 at 11:08:07AM +0800, Hayes Wang wrote:
> Reduce the control transfer if all bytes of first or the last DWORD are
> written.
> 
> The original method is to split the control transfer into three parts
> (the first DWORD, middle continuous data, and the last DWORD). However,
> they could be combined if whole bytes of the first DWORD or last DWORD
> are written. That is, the first DWORD or the last DWORD could be combined
> with the middle continuous data, if the byte_en is 0xff.

How often is byte_en 0xff? Do you have some benchmark numbers to show
it is worth the complexity?

   Andrew