netdev - Re: [PATCH v2 05/11] firewall: introduce stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 12:22:12 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Gatien Chevallier <gatien.chevallier@...s.st.com>
Cc: Oleksii_Moisieiev@...m.com, gregkh@...uxfoundation.org,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, alexandre.torgue@...s.st.com, vkoul@...nel.org,
	jic23@...nel.org, olivier.moysan@...s.st.com,
	arnaud.pouliquen@...s.st.com, mchehab@...nel.org,
	fabrice.gasnier@...s.st.com, andi.shyti@...nel.org,
	ulf.hansson@...aro.org, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, hugues.fruchet@...s.st.com, lee@...nel.org,
	will@...nel.org, catalin.marinas@....com, arnd@...nel.org,
	richardcochran@...il.com, Frank Rowand <frowand.list@...il.com>,
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-iio@...r.kernel.org, alsa-devel@...a-project.org,
	linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
	netdev@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-serial@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 05/11] firewall: introduce stm32_firewall framework

On Tue, Jul 25, 2023 at 06:40:58PM +0200, Gatien Chevallier wrote:

...

> diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c

...

> +int stm32_firewall_controller_register(struct stm32_firewall_controller *firewall_controller)
> +{
> +	struct stm32_firewall_controller *ctrl;
> +
> +	pr_info("Registering %s firewall controller\n", firewall_controller->name);
> +
> +	if (!firewall_controller)
> +		return -ENODEV;

HI Gatien,

Sorry, one more on this patch, that I missed before sending my previous
email.

firewall_controller is checked for NULL here.
But it is already dereferenced on the line above the check.

Flagged by Smatch.

...