netdev - Re: [PATCH net-next v2] page_pool: split types and declarations from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16b4ab57-dfb0-2c1d-9be1-57da30dff3c3@intel.com>
Date: Wed, 26 Jul 2023 12:43:30 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Alexander H Duyck <alexander.duyck@...il.com>
CC: Yunsheng Lin <linyunsheng@...wei.com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>, Wei Fang
	<wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark Wang
	<xiaoning.wang@....com>, NXP Linux Team <linux-imx@....com>, Sunil Goutham
	<sgoutham@...vell.com>, Geetha sowjanya <gakula@...vell.com>, "Subbaraya
 Sundeep" <sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>, "Saeed
 Mahameed" <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	"Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend
	<john.fastabend@...il.com>, Felix Fietkau <nbd@....name>, Lorenzo Bianconi
	<lorenzo@...nel.org>, "Ryder Lee" <ryder.lee@...iatek.com>, Shayne Chen
	<shayne.chen@...iatek.com>, "Sean Wang" <sean.wang@...iatek.com>, Kalle Valo
	<kvalo@...nel.org>, "Matthias Brugger" <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Ilias
 Apalodimas <ilias.apalodimas@...aro.org>, <linux-rdma@...r.kernel.org>,
	<bpf@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next v2] page_pool: split types and declarations from
 page_pool.h

From: Alexander H Duyck <alexander.duyck@...il.com>
Date: Tue, 25 Jul 2023 08:47:46 -0700

> On Tue, 2023-07-25 at 21:12 +0800, Yunsheng Lin wrote:
>> Split types and pure function declarations from page_pool.h
>> and add them in page_pool/types.h, so that C sources can
>> include page_pool.h and headers should generally only include
>> page_pool/types.h as suggested by jakub.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
>> Suggested-by: Jakub Kicinski <kuba@...nel.org>
>> CC: Alexander Lobakin <aleksander.lobakin@...el.com>

[...]

>> +/* Caller must provide appropriate safe context, e.g. NAPI. */
>> +void page_pool_update_nid(struct page_pool *pool, int new_nid);
>> +
>> +#endif /* _NET_PAGE_POOL_H */
> 
> 
> This seems kind of overkill for what is needed. It seems like the
> general thought process with splitting this was so that you had just
> the minimum of what is needed to support skbuff.h and the functions
> declared there. The rest of this would then be added via the .h to the
> .c files that will actually be calling the functions.
> 
> By that logic I think the only thing we really need is the function
> declaration for page_pool_return_skb_page moved into skbuff.h. We could
> then just remove page_pool.h from skbuff.h couldn't we?

This patch is not to drop page_pool.h include from skbuff.h.
This is more future-proof (since I'm dropping this include anyway in my
series) to have includes organized and prevent cases like that one with
skbuff.h from happening. And to save some CPU cycles on preprocessing if
that makes sense.

> 
> Another thing we could consider doing is looking at splitting things up
> so that we had a include file in net/core/page_pool.h to handle some of
> the cases where we are just linking the page_pool bits to other core
> file bits such as xdp.c and skbuff.c.

Thanks,
Olek