netdev - Re: [v4 bpf 2/2] bpf: selftests: add lwt redirect regression test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8f1b5a70-5b13-4ea9-023b-a5565c07b949@web.de>
Date: Wed, 26 Jul 2023 13:04:38 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yan Zhai <yan@...udflare.com>, bpf@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-kselftest@...r.kernel.org,
 netdev@...r.kernel.org, kernel-team@...udflare.com
Cc: Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jakub Sitnicki <jakub@...udflare.com>, Jiri Olsa <jolsa@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Jordan Griege <jgriege@...udflare.com>, KP Singh <kpsingh@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Mykola Lysenko <mykolal@...com>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 Song Liu <song@...nel.org>, Stanislav Fomichev <sdf@...gle.com>,
 Yonghong Song <yhs@...com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v4 bpf 2/2] bpf: selftests: add lwt redirect regression test
 cases

>     See also:
>     https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
>
> I don’t follow the purpose of this reference.

You picked a corresponding advice up for the first update step
of this patch series.

> This points to user impact but this is a selftest,

The linked document contains descriptions for general Linux development requirements,
doesn't it?

> so I don’t see any user impact here.

Please reconsider such a view.

> Or is there anything I missed?

Yes.

Can you adhere to published guidelines at any more places?

>     Can remaining wording weaknesses be adjusted accordingly?
>
> I am not following this question . Can you be more specific or provide an example?

I interpret word combinations (like the following) also as update candidates.

* lwt redirect regression

* handling are

Regards,
Markus