netdev - RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 11:10:10 +0000
From: Bough Chen <haibo.chen@....com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
CC: "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"wg@...ndegger.com" <wg@...ndegger.com>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, dl-linux-imx <linux-imx@....com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-can@...r.kernel.org"
	<linux-can@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by
 GPR

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: 2023年7月26日 17:57
> To: Bough Chen <haibo.chen@....com>
> Cc: robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> wg@...ndegger.com; kernel@...gutronix.de; dl-linux-imx
> <linux-imx@....com>; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; devicetree@...r.kernel.org;
> linux-can@...r.kernel.org; netdev@...r.kernel.org
> Subject: Re: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by
> GPR
> 
> On 26.07.2023 17:09:07, haibo.chen@....com wrote:
> > From: Haibo Chen <haibo.chen@....com>
> >
> > imx93 A0 chip use the internal q-channel handshake signal in LPCG and
> > CCM to automatically handle the Flex-CAN stop mode. But this method
> > meet issue when do the system PM stress test. IC can't fix it easily.
> > So in the new imx93 A1 chip, IC drop this method, and involve back the
> > old way，use the GPR method to trigger the Flex-CAN stop mode signal.
> > Now NXP claim to drop imx93 A0, and only support
> > imx93 A1. So here add the stop mode through GPR.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 4ec9df78f205..d2040019e9c7 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -319,6 +319,7 @@ flexcan1: can@...a0000 {
> >  				assigned-clock-parents = <&clk
> IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> >  				assigned-clock-rates = <40000000>;
> >  				fsl,clk-source = /bits/ 8 <0>;
> > +				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;
> 
> I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed to be
> "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different problem to
> patch :)

Yes, this is a typo.
> 
> AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3 QCHANNEL
> DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is the correct reg?
> 

Imx93 A1 doc has some update, I double confirm with the internal doc and IC team, the setting is correct.
I also test on imx93-9x9 qsb board, system can be wakeup by this setting.

> >  				status = "disabled";
> >  			};
> >
> > @@ -591,6 +592,7 @@ flexcan2: can@...b0000 {
> >  				assigned-clock-parents = <&clk
> IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> >  				assigned-clock-rates = <40000000>;
> >  				fsl,clk-source = /bits/ 8 <0>;
> > +				fsl,stop-mode = <&wakeupmix_gpr 0x0C 2>;
> 
> looks plausible, please use lower case for hex addresses.

My bad, will fix.

Best Regards
Haibo Chen

> 
> >  				status = "disabled";
> >  			};
> >
> > --
> > 2.34.1
> >
> >
> 
> regards,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |