netdev - Re: [PATCH v3 4/5] SUNRPC: Revert e0a912e8ddba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6618.1690373671@warthog.procyon.org.uk>
Date: Wed, 26 Jul 2023 13:14:31 +0100
From: David Howells <dhowells@...hat.com>
To: Chuck Lever <cel@...nel.org>
Cc: dhowells@...hat.com, linux-nfs@...r.kernel.org,
    netdev@...r.kernel.org, Chuck Lever <chuck.lever@...cle.com>
Subject: Re: [PATCH v3 4/5] SUNRPC: Revert e0a912e8ddba

Chuck Lever <cel@...nel.org> wrote:

> Flamegraph analysis showed that the cork/uncork calls consume
> nearly a third of the CPU time spent in svc_tcp_sendto(). The
> other two consumers are mutex lock/unlock and svc_tcp_sendmsg().
> 
> Now that svc_tcp_sendto() coalesces RPC messages properly, there
> is no need to introduce artificial delays to prevent sending
> partial messages.
> 
> After applying this change, I measured a 1.2K read IOPS increase
> for 8KB random I/O (several percent) on 56Gb IP over IB.
> 
> Signed-off-by: Chuck Lever <chuck.lever@...cle.com>

Reviewed-by: David Howells <dhowells@...hat.com>