netdev - Re: [PATCH net-next v2] page_pool: split types and declarations from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230726084742.7dc67c79@kernel.org>
Date: Wed, 26 Jul 2023 08:47:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Ilias Apalodimas <ilias.apalodimas@...aro.org>, Yunsheng Lin
 <linyunsheng@...wei.com>, <davem@...emloft.net>, <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Eric Dumazet
 <edumazet@...gle.com>, Wei Fang <wei.fang@....com>, Shenwei Wang
 <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, NXP Linux Team
 <linux-imx@....com>, Sunil Goutham <sgoutham@...vell.com>, Geetha sowjanya
 <gakula@...vell.com>, "Subbaraya Sundeep" <sbhatta@...vell.com>, hariprasad
 <hkelam@...vell.com>, "Saeed Mahameed" <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, "Alexei Starovoitov" <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, "Jesper Dangaard Brouer" <hawk@...nel.org>, John
 Fastabend <john.fastabend@...il.com>, Felix Fietkau <nbd@....name>, Lorenzo
 Bianconi <lorenzo@...nel.org>, "Ryder Lee" <ryder.lee@...iatek.com>, Shayne
 Chen <shayne.chen@...iatek.com>, "Sean Wang" <sean.wang@...iatek.com>,
 Kalle Valo <kvalo@...nel.org>, "Matthias Brugger" <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 <linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>,
 <linux-wireless@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next v2] page_pool: split types and declarations
 from page_pool.h

On Wed, 26 Jul 2023 12:48:05 +0200 Alexander Lobakin wrote:
> > I prefer the more systematic approach of creating a separate types.h
> > file, so I don't have to keep chasing people or cleaning up the include
> > hell myself. I think it should be adopted more widely going forward,
> > it's not just about the page pool.  
> 
> I have this patch reworked to introduce
> include/net/page_pool/{types,helpers}.h in my tree, maybe someone could
> take a quick look[0] and say if this works while I'm preparing the next
> version for sending? Not the most MLish way, I know :s
> 
> [0]
> https://github.com/alobakin/linux/commit/19741ee072c32eb1d30033cd4fcb236d1c00bfbf

LGTM!