netdev - Re: [PATCH v2] scripts: get_maintainer: steer people away from using file paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 09:45:25 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Joe Perches <joe@...ches.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	geert@...ux-m68k.org, gregkh@...uxfoundation.org, netdev@...r.kernel.org, 
	workflows@...r.kernel.org, mario.limonciello@....com
Subject: Re: [PATCH v2] scripts: get_maintainer: steer people away from using
 file paths

On Wed, 26 Jul 2023 at 09:23, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 26 Jul 2023 08:43:30 -0700 Joe Perches wrote:
> > > Print a warning when someone tries to use -f and remove
> > > the "auto-guessing" of file paths.
> >
> > Nack on that bit.
> > My recollection is it's Linus' preferred mechanism.
>
> Let Linus speak for himself, hopefully he's okay with throwing
> in the -f.

It's not the '-f' that would be the problem - that's how the script
used to work long ago, and I still occasionally end up adding the -f
by habit.

So removing the auto-guessing of file paths wouldn't be a problem.

But the annoying warning is wrong.

I use get_maintainers all the time, and I *only* use it for file
paths. If I know the commit, I get the list of people from the commit
itself, so why should I *ever* use that script if I have a patch?

So the whole "use of get_maintainers is only for patches, and we
should warn about file paths" is insane.

No. If I get that patch, I will remove the warning. The *only* reason
for me to ever use that script is for the file path lookup.

             Linus