netdev - Re: [PATCH v2 net] net: flower: fix stack-out-of-bounds in fl_set_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 20:09:05 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	syzbot <syzkaller@...glegroups.com>,
	Zahari Doychev <zdoychev@...linear.com>,
	Simon Horman <simon.horman@...igine.com>,
	Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH v2 net] net: flower: fix stack-out-of-bounds in
 fl_set_key_cfm()

On Wed, Jul 26, 2023 at 02:58:15PM +0000, Eric Dumazet wrote:
> Typical misuse of
> 
> 	nla_parse_nested(array, XXX_MAX, ...);
> 
> array must be declared as
> 
> 	struct nlattr *array[XXX_MAX + 1];
> 
> v2: Based on feedbacks from Ido Schimmel and Zahari Doychev,
> I also changed TCA_FLOWER_KEY_CFM_OPT_MAX and cfm_opt_policy
> definitions.
> 
[...]

> 
> Fixes: 7cfffd5fed3e ("net: flower: add support for matching cfm fields")
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Zahari Doychev <zdoychev@...linear.com>
> Cc: Simon Horman <simon.horman@...igine.com>
> Cc: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Thanks