netdev - Re: [PATCH 27/29] bonding: 3ad: Remove unused declaration bond_3ad_update_lacp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jul 2023 13:45:27 -0700
From: Jay Vosburgh <j.vosburgh@...il.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: andy@...yhouse.net, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, jon.toppins+linux@...il.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, liuhangbin@...il.com
Subject: Re: [PATCH 27/29] bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active()

On 7/26/23, YueHaibing <yuehaibing@...wei.com> wrote:
> This is not used since commit 3a755cd8b7c6 ("bonding: add new option
> lacp_active")

To be clear, it appears that the cited commit added the declaration of
bond_3ad_upate_lacp_active() to bond_3ad.h, but did not add the actual
function definition.  A brief search suggests that the function has
never existed.

Regardless, the declaration shouldn't be there now.

Acked-by: Jay Vosburgh <j.vosburgh@...il.com>


> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  include/net/bond_3ad.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h
> index a016f275cb01..c5e57c6bd873 100644
> --- a/include/net/bond_3ad.h
> +++ b/include/net/bond_3ad.h
> @@ -301,7 +301,6 @@ int  __bond_3ad_get_active_agg_info(struct bonding
> *bond,
>  int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
>  			 struct slave *slave);
>  int bond_3ad_set_carrier(struct bonding *bond);
> -void bond_3ad_update_lacp_active(struct bonding *bond);
>  void bond_3ad_update_lacp_rate(struct bonding *bond);
>  void bond_3ad_update_ad_actor_settings(struct bonding *bond);
>  int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats
> *stats);
> --
> 2.34.1
>
>