[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZMGRSFy04JHCthin@x130>
Date: Wed, 26 Jul 2023 14:34:00 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
Tariq Toukan <tariqt@...dia.com>, Adham Faris <afaris@...dia.com>,
Gal Pressman <gal@...dia.com>
Subject: Re: [net-next 02/14] net/mlx5: Expose NIC temperature via hardware
monitoring kernel API
On 25 Jul 20:31, Jakub Kicinski wrote:
>On Mon, 24 Jul 2023 15:44:14 -0700 Saeed Mahameed wrote:
>> Expose NIC temperature by implementing hwmon kernel API, which turns
>> current thermal zone kernel API to redundant.
>>
>> For each one of the supported and exposed thermal diode sensors, expose
>> the following attributes:
>> 1) Input temperature.
>> 2) Highest temperature.
>> 3) Temperature label.
>> 4) Temperature critical max value:
>> refers to the high threshold of Warning Event. Will be exposed as
>> `tempY_crit` hwmon attribute (RO attribute). For example for
>> ConnectX5 HCA's this temperature value will be 105 Celsius, 10
>> degrees lower than the HW shutdown temperature).
>> 5) Temperature reset history: resets highest temperature.
>>
>> For example, for dualport ConnectX5 NIC with a single IC thermal diode
>> sensor will have 2 hwmon directories (one for each PCI function)
>> under "/sys/class/hwmon/hwmon[X,Y]".
>>
>> Listing one of the directories above (hwmonX/Y) generates the
>> corresponding output below:
>>
>> $ grep -H -d skip . /sys/class/hwmon/hwmon0/*
>
>I missed it glancing on the series yesterday because it's just
>a warning in pw - we should really get hwmon folks and ML CCed
>on this one.
Ok I will remove this patch from the series and send it separately with the
proper CCs.
>--
>pw-bot: cr
Powered by blists - more mailing lists