netdev - Re: [PATCH net-next v1 1/3] doc/netlink: Add a schema for netlink-raw families

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD4GDZy5BC6F_Asopz4WRnZ5KBasdHpchoseafcKwbBZ3ZLySQ@mail.gmail.com>
Date: Wed, 26 Jul 2023 22:48:54 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 1/3] doc/netlink: Add a schema for netlink-raw families

On Wed, 26 Jul 2023 at 22:09, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 25 Jul 2023 17:22:03 +0100 Donald Hunter wrote:
> >  - add an id property to mcast-group definitions
>
> nit: my first thought would be to call it "value" rather than "id"
> to stick with the naming we have to other objects. Any pros/cons
> you see?

Yep, that makes sense. I wasn't sure about "id" anyway but it didn't occur
to me to align with "value".

> Other than that the big ask would be to update the documentation :)

Do you mind if I update the docs as a follow up patch? I'm on holiday for
the next 10 days - I should have time to respin this patchset but maybe
not to work on docs as well.