netdev - Re: [PATCH] net: move comment in ndisc_router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3f90818-3991-4b76-6f3a-9e9aed976dea@kernel.org>
Date: Tue, 25 Jul 2023 17:21:04 -0600
From: David Ahern <dsahern@...nel.org>
To: Patrick Rohr <prohr@...gle.com>, "David S . Miller" <davem@...emloft.net>
Cc: Linux Network Development Mailing List <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: move comment in ndisc_router_discovery

On 7/25/23 12:51 PM, Patrick Rohr wrote:
> Move setting the received flag comment to the appropriate section.
> 
> Signed-off-by: Patrick Rohr <prohr@...gle.com>
> ---
>  net/ipv6/ndisc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index eeb60888187f..0a29a4626194 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -1266,10 +1266,6 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
>  	}
>  #endif
>  
> -	/*
> -	 *	set the RA_RECV flag in the interface
> -	 */
> -
>  	in6_dev = __in6_dev_get(skb->dev);
>  	if (!in6_dev) {
>  		ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",
> @@ -1297,6 +1293,10 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
>  	}
>  #endif
>  
> +	/*
> +	 *	set the RA_RECV flag in the interface
> +	 */
> +
>  	if (in6_dev->if_flags & IF_RS_SENT) {
>  		/*
>  		 *	flag that an RA was received after an RS was sent

There is already a comment here, so just delete the previous one.